feat: Get rid of MessageState::{OutPreparing, OutMdnRcvd} in the db#8127
Merged
feat: Get rid of MessageState::{OutPreparing, OutMdnRcvd} in the db#8127
Conversation
iequidoo
force-pushed
the
iequidoo/drop-unused-message-states
branch
2 times, most recently
from
1a27244 to
f5322d2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
iequidoo
force-pushed
the
iequidoo/drop-unused-message-states
branch
2 times, most recently
from
f5322d2 to
7051a48
Compare
iequidoo
force-pushed
the
iequidoo/drop-unused-message-states
branch
2 times, most recently
from
85ec8ce to
b8b8e30
Compare
iequidoo
force-pushed
the
iequidoo/drop-unused-message-states
branch
from
b8b8e30 to
0b78fba
Compare
Hocuri
reviewed
May 7, 2026
| sql.execute_migration( | ||
| " | ||
| UPDATE msgs SET state=26 WHERE state=28; -- Change OutMdnRcvd to OutDelivered. | ||
| UPDATE msgs SET state=19 WHERE state=18; -- Change OutPreparing to OutDraft. |
Collaborator
There was a problem hiding this comment.
Should not be OutDraft; if a message has been in OutPreparing for over a year, then it's not interesting anymore. Can be OutDelivered or OutFailed.
Collaborator
Author
There was a problem hiding this comment.
Agree, OutFailed looks good
Hocuri
approved these changes
May 7, 2026
Collaborator
Hocuri
left a comment
Hocuri
left a comment
There was a problem hiding this comment.
LGTM after comment is addressed
`OutPreparing` is deprecated since 2024-12-07, replace it with `OutFailed`, such messages are probably not interesting anymore. `OutMdnRcvd` is not used in the db for new messages since a30c6ae, `OutDelivered` is stored instead.
iequidoo
force-pushed
the
iequidoo/drop-unused-message-states
branch
from
0b78fba to
8bd0ef5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OutPreparingis deprecated since 2024-12-07, replace it withOutFailed, such messages areprobably not interesting anymore.
OutMdnRcvdis not used in the db for new messages sincea30c6ae,
OutDeliveredis stored instead.Noticed this when doing #8121